Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/package/tag): Better messages when tagging an existing package #4938

Merged
merged 5 commits into from
Jul 29, 2024
Merged

fix(cli/package/tag): Better messages when tagging an existing package #4938

merged 5 commits into from
Jul 29, 2024

Conversation

xdoardo
Copy link
Contributor

@xdoardo xdoardo commented Jul 17, 2024 •
edited
Loading

(Closes #4801, closes #4707, fixes RUN-276)

This PR adds a better message shown to users in the case they try to tag two different releases of the same package with the same version:

Screenshot 2024-07-17 at 13 48 22

@xdoardo xdoardo requested a review from syrusakbary as a code owner July 17, 2024 11:50
@xdoardo xdoardo requested review from theduke and ayys and removed request for ayys July 18, 2024 06:43
@xdoardo xdoardo requested a review from theduke July 23, 2024 13:40
@xdoardo xdoardo merged commit 803c0be into main Jul 29, 2024
62 of 63 checks passed
@xdoardo xdoardo deleted the fix-deploy-named-bump branch July 29, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@xdoardo @syrusakbary @theduke